Repository navigation
Conversation
Contributor
Author
|
@jasonvarga Could you maybe take a look at this? |
Contributor
Author
|
I've added a test case for the functionality this addresses, if you checkout that commit (before the fix), you can see that the duplicated entry is missing from the tree structure. |
Contributor
Author
|
@duncanmcclean Is there something missing that is preventing this from being reviewed? |
Member
|
Nope, we just haven't got around to reviewing it yet. We'll get to it when we can. In the meantime, you can pull this PR into your project with a composer patch. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11319
Changes
it_adds_duplicated_entry_to_treecase toDuplicateEntryaction tests